kmesh: waypoints: Fix broken back link on Waypoint detail page - #1217
Open
itvi-1234 wants to merge 1 commit into
Open
kmesh: waypoints: Fix broken back link on Waypoint detail page#1217itvi-1234 wants to merge 1 commit into
itvi-1234 wants to merge 1 commit into
Conversation
Resolve the back link via createRouteURL(routeName) instead of a raw literal path, matching the pattern used by other plugins. Raw paths aren't cluster-prefixed, so clicking Back navigated to a URL that didn't match any registered route. Signed-off-by: Sumit Goyal <rjsumit71@gmail.com>
itvi-1234
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 18, 2026 14:36
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Waypoint detail page’s Back link by generating a cluster-aware URL from the registered route name.
Changes:
- Uses
Router.createRouteURLfor both Waypoint detail states. - References the registered Waypoint list route name.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the back link via createRouteURL(routeName) instead of a raw literal path, matching the pattern used by other plugins. Raw paths aren't cluster-prefixed, so clicking Back navigated to a URL that didn't match any registered route.