fix(karpenter): fix Age column sort in event lists - #1213
Open
magic-peach wants to merge 1 commit into
Open
Conversation
The sort comparator read n1.lastTimestamp/n2.lastTimestamp directly, but Event only exposes that field through an internal getValue() call, not as a public property, so both sides were always undefined and the comparator always returned NaN. Clicking the Age header did nothing. Switched to lastOccurrence, the getter the column already uses to render the displayed age, which also correctly falls back to series.lastObservedTime for EventSeries-based repeated events (the common case for karpenter's own scaling/consolidation events). Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
magic-peach
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 18, 2026 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Age column's sort comparator reads
n1.lastTimestamp/n2.lastTimestampstraight off the event objects.Eventdoesn't expose that as a public property though, only internally viagetValue('lastTimestamp'), so both sides come backundefinedandnew Date(undefined).getTime()isNaNevery time. The comparator always returnsNaN, so clicking the Age header never actually reorders anything.Switched to
lastOccurrence, which is the getter the same column already uses to render what it shows the user. It also handles EventSeries correctly (falls back toseries.lastObservedTime), whichlastTimestampdoesn't — that's the normal shape for karpenter's own repeated scaling/consolidation events, so this wasn't just an edge case.Pulled the comparator out into its own exported function so it's testable without needing a live Event instance.