including compile hook to run makefile automatically by rebar3#56
Open
muszbek wants to merge 1 commit into
Open
including compile hook to run makefile automatically by rebar3#56muszbek wants to merge 1 commit into
muszbek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for issue #55
I understand that the makefile does all the erlang compilation (without using rebar3), and the rebar.config is quite empty.
Therefore running the makefile as part of the rebar3 compilation duplicates some parts of the build.
However this solution fixes my problem (that I want to use erlport in my rebar3 project), and besides having some warnings it seems safe to me.