feat!: require positional template; drop bare stdin and --template - #942
Merged
Conversation
Fixes #940 Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage Report for CI Build 30282784197Warning No base build found for commit Coverage: 99.528%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Make template a required positional arg (drop --template) for v11 per #586; stdin template remains unsupported without a special error. Co-authored-by: Cursor <cursoragent@cursor.com>
harttle
changed the title
Revert the positional-only template change. Keep --template as the primary API; stdin template remains unsupported without a special error. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep @- for --template and --context; only the legacy bare-stdin-as-template fallback stays removed. Co-authored-by: Cursor <cursoragent@cursor.com>
Support positional <template> alongside --template/-t for compatibility; error if both are set and differ. Bare stdin template remains removed; @- still works. Co-authored-by: Cursor <cursoragent@cursor.com>
harttle
changed the title
harttle
changed the title
Template is positional-only; bare stdin template and --template/-t are both removed. Keep @- for template and --context. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@-.--template/-tremoved. Template is a required positional argument only.--context @-and@pathstill work.Fixes #940
Test plan
npx liquidjs '{{ hello | capitalize }}'rendersnpx liquidjs --template '...'fails as unknown optionnpx liquidjs @./file.liquidreads template from fileecho 'Hello, {{ name }}!' | npx liquidjs @- --context '{name:Snake}'worksecho '{name:Snake}' | npx liquidjs 'Hello, {{ name }}!' --context @-works