fix: logoBuffer applies mitre and box caps on named BufferOp - #58
Merged
grootstebozewolf merged 3 commits intoAug 16, 2026
Merged
Conversation
Hero halo is logoLines + logoBuffer: toLinear at a sagitta tied to the buffer distance, then one BufferOp on the whole linearized ISO/IEC 13249-3 MultiCurve. JOIN_MITRE and CAP_SQUARE now both land. CHORD-PATH / NAMED-APPROX. Not a laser. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
The first bulge point sat under the T-bar offset, so the raw control-point BufferOp covered it. The J mitre tip is likewise occluded; JOIN_MITRE is locked by equalsExact against the named path. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
Hero stays toLinear(0.0) (CircularArcDensifier 1% radius) + one BufferOp. JOIN_MITRE uses DEFAULT_MITRE_LIMIT, not 0. CAP_SQUARE stays. Do not weld letters. Do not flatten bufferWithParams. CHORD-PATH / NAMED-APPROX. Not a laser. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hero halo is
logoLines+logoBuffer(toLinear(0.0)+ BufferOp) at distance 4, JOIN_MITRE withDEFAULT_MITRE_LIMIT(5, not 0), CAP_SQUARE (box caps). One BufferOp on the whole linearized ISO/IEC 13249-3 MultiCurve (J + T-stem + T-crossbar + S). HOLD merge.Honesty
BufferOp/ CHORD-PATH / NAMED-APPROX.toLinear(0.0)is CircularArcDensifier 1% of radius (J R=25 → ε=0.25; S R=17.5 → ε=0.175), then chords. Not a laser. Not clothoid. Not feat: TestBuilder logoClothoid named clothoid halo #55. NeverisApproximate()=false.Quiet defaults, written not flattened
Buffer.bufferafter logo in A:CurveOps.buffer→CurveExact.buffernull (not a disc) →linearise(extent*1e-6)→Geometry.buffer(4)with no BufferParameters. Cap/Join widgets are hidden. CAP_ROUND + JOIN_ROUND.Buffer.bufferWithParams: params reach BufferOp, but no linearize (control-point chords). Empty Quadrant Segs → 0. Empty Mitre Limit → 0.0 (JOIN_MITRE bevels). This PR does not add flatten there.BufferCurveSetBuilder.addCollection→ one curveList → one node/polygonize). T–S gap is 5; at d=4, 4+4>5 so sausages overlap. “Not one halo” is a thick 4-stroke wordmark, not BufferOp forgetting to union. Real disconnect paths:Buffer.bufferEach/ Each A (off by default), or empty A +Buffer.bufferNPE. Do not weld J/T/S. Do not union letters inlogoLines.What changed (logoBuffer only)
Old
logoBufferalready densified at 1% radius and ran one BufferOp with CAP_SQUARE. The named gap was JOIN_ROUND (default) and no explicit mitre limit.JOIN_MITREandDEFAULT_MITRE_LIMIT(not 0).CAP_SQUARE.toLinear(0.0)+ one BufferOp.Tests
JTSFunctionsLogoBufferTest(5) andJTSFunctionsLogoLinesCurveTest(4) — 9 run, 0 failed. Locks: four-member MultiCurve stays un-welded; overlapping sausages are already one polygon (bufferEach stays 4); result equalstoLinear(0.0)+ BufferOp(mitre, box, limit 5) and differs from JOIN_ROUND and from mitreLimit 0; box-cap corner lands; S-bowl bulge is on the halo and off the control-point chainsaw. NoisApproximate()=false.Base is #7 @ 075740e. Does not revert #54 or #57. Does not join #55, #52, or #38.