fix: inspector zoom CCE on empty GeometryTree - #48
Merged
grootstebozewolf merged 1 commit intoAug 16, 2026
Conversation
Empty-state DefaultMutableTreeNode is not a GeometricObjectNode. Return null from getGeometryFromNode and no-op nextPath instead of ClassCastException / NPE (issue #3). Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3 (FCP-S). Draft only — do not merge.
Problem
Inspector zoom on an empty geometry tree throws:
The empty-state model is a plain
DefaultMutableTreeNode("No geometry shown"). The cell renderer already guardsinstanceof GeometricObjectNode; zoom and next-node did not.nextPathalso raw-casts the last path component and parent, and NPEs when the selected node is the root (parentPath == null).Change
Touch only
GeometryTreePanelplus a focused unit test.getGeometryFromNode: return null unlessvalue instanceof GeometricObjectNode.nextPath: if the last component or parent is not aGeometricObjectNode, orparentPathis null, return the current path (no-op).Test
GeometryTreePanelEmptyTestconstructs the empty panel, selects the default root, and asserts:getSelectedGeometry()is null (no CCE)moveToNextNodestays on that path (no NPE)No inspector redesign. No new TestBuilder. No Bar 2 / #38 / #27 / #47. No public noder. No new rung.