TestBuilder JTS logoLines as curves, not densified polylines - #42
Merged
cursor[bot] merged 3 commits intoAug 16, 2026
Merged
Conversation
Replace GeometricShapeFactory 10-point polyline arcs in logoLines with honest CircularString members assembled via createCircularString then createCompoundCurve(LineString[]). J is stem+quarter+base, S is straights+two semicircles, T stays straight, union is a MultiCurve. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
Exact hull for CompoundCurve / stadium / two-cap mixes: a CurvePolygon whose shell is the exposed arcs plus supporting tangents. Disc and single-arc paths stay as they were. Clothoid and all-straight members are a named null so densify stays the fallback and is never flagged exact. Not a noder; not Bar 2; not a merge into #7. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
Arc vertices from cos/sin were within eps of the input points but not equal, so the legacy LinearRing derived from the CompoundCurve shell rejected the ring. Snap junctions and pin the bulge on the arc member rather than the densified distance path. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBuilder JTS
logoLinesis curves. Not Bar 2. Do not merge into #7.What
JTSFunctions.logoLinesbuilt the JTS logo withGeometricShapeFactory.createArc(10-point polylines) thencreateLineString. The J hook and both S bowls were fake arcs.This draft returns real curve geometry:
CompoundCurve: stem (top + vertical) + quarter-circleCircularString+ baseLineStringsCompoundCurve: straights + two semicircleCircularStringsMultiCurve. TestBuilder already walks collections and paints arcs throughCurveShapeWriter.union()would linearise.Construction uses the honest factory:
createCircularStringthencreateCompoundCurve(new LineString[]{ ... }). NevercreateCompoundCurve(CoordinateSequence)(the polyline lie on this branch).logoBufferstill usesBufferOp+ square caps. It linearises the curve result first so the buffer sees the arcs, not control-point chords. That densify is not claimed exact. No laser buffer.jtsVersionis unchanged.Out of scope
*Curved*)JTSFunctionsLogoLinesCurveTestPin
JTSFunctionsLogoLinesCurveTestassertslogoLinescontainsCircularString/CompoundCurvemembers, that J/S are not 10-pointLineStringarcs fromGeometricShapeFactory, and thatjtsVersionstill delegates toJTSVersion.CURRENT_VERSION.Base
Draft off
feature/sfa-curve-rgr(#7 @ 8e39e39). Do not merge into #7 or locationtech master.