HP.2 CurveHotPixel in jts-curve (arc ∩ pixel) - #29
Draft
grootstebozewolf wants to merge 1 commit into
Draft
Conversation
Package-private pixel around one node. Intersection is circle–square in the scaled (squared) metric, not the supporting chord and not core HotPixel.intersectsScaled. Pins the (0, 5) tangent on the existing H-SHELL-N-ODD fixtures. Does not snap leave-angles or walk faces. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26 @ 1b06a57. Sibling of P2.5.5, not the 74-file blast.
HP.0 / HP.1 done. This is HP.2 only.
What
CurveHotPixelisA package-private pixel around one node in
org.locationtech.jts.operation.overlayng.curve. The square / half-open / scale contract matches snap-rounding (width1/scale, left and bottom closed, top and right open). Intersection is arc ∩ pixel in the squared metric: circle–square / arc–AABB in scaled space, then restricted to the sweep. Not the supporting chord. NotHotPixel.intersectsScaled. Not a densified polyline.The first pin is the H-SHELL-N-ODD tangent at
(0, 5)(documented scale10, pixel width0.1):d²_max < r²).y=0, STADIUM_ODD capy=4) miss. That is the lieintersectsScaledon a chord would tell.This rung does not snap leave-angles and does not walk faces.
Never list (catalog)
intersectsScaledon a chord called circularSnapRoundingNoderflaggedisApproximate()=falseorg.locationtech.jts.noding.snapround/ coreHotPixel.javafeature/sfa-curve-rgr/ PR SFA/SQL-MM curve awareness: Curve rename, arc-aware operations, OverlayNGCurve ratchet (#1195 RGR series) #7What this is not
HotPixel/ coreSegmentStringtestCurvatureOrderWalksWrongRings, 18.42 vs pair-kit13π+2)testN3TangentStampsNull/missReasonP2.5.4 tangent leave-angle)Verify
Same suite as #26. Slack 15%. OverlayNGCurve never Curved. All green after this revision:
CurveSegmentStringTest28 / 0 (testN3TangentStampsNullandtestCurvatureOrderWalksWrongRingsunchanged; three HP.2 pins added)CompoundCurveShellOverlayTest27 / 0CircularArcOverlayTest11 / 0CircularDiscOverlayTest12 / 0CircularDiscPolygonOverlayTest7 / 0CircularLineOverlayTest7 / 0OverlayNGCurvePhase0Test19 / 0OverlayNGCurveRatchetTest50 / 0OverlayNGCurvePerfGateTest82 / 0 (15% slack)jts-curvesucceededNo noder was written. Core
HotPixel.javawas not edited. HP.1 pin and P2.5.4 stamp unchanged. HP.3 / HP.4 / P2.5.5 were not started.