fix: 3-point CurvePolygon hole paints arcs, not the chord triangle - #118
Draft
grootstebozewolf wants to merge 2 commits into
Draft
fix: 3-point CurvePolygon hole paints arcs, not the chord triangle#118grootstebozewolf wants to merge 2 commits into
grootstebozewolf wants to merge 2 commits into
Conversation
A hole that is still CIRCULARSTRING / COMPOUNDCURVE (ISO/IEC 13249-3) must draw the arc(s) on the canvas. An open CircularString is odd and at least three controls; a closed CS ring is five tokens first=last. Do not treat (A,B,C,A) as a valid CircularString ring. Paint-only complementary close; do not invent WKT. HOLD merge. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
The attached ring is two 4-control CircularStrings, first=last. A major-arc hole closed through the antipode redrew the same majority, so the canvas stroked the hole on the disc. Paint uses the complementary sweep mid so the inner CIRCULARSTRING punches. WKT unchanged. ISO/IEC 13249-3. HOLD merge. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
Owner
Author
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114 only. Do not merge. Do not join #60 #82 #92 #59 #102.
Observed (UX RC4 witness)
Type honest. Canvas HOLD. Hole is a stroke on the disc, not a punch.
Attached ring (do not invent another)
Two 4-control CircularStrings, first=last. No flatten. A pane keeps this WKT.
Expected
With that WKT loaded as A, the inner CircularString punches a hole (interior). Canvas draws the hole arcs, not the 3-point/4-point chord triangle.
Cause
The hole specified arc is a majority of its circumcircle. Closing through the antipode of the mid control redrew that same majority, so the path was a second stroke, not a disc.
Change (paint-path only)
CurveShapeWritercloses a 4-control first=last CircularString with the complementary sweep mid (the arc from last distinct control back to start that does not contain the specified interior control). WKT is not rewritten.ISO/IEC 13249-3. No DOI. Not FCP-H. Not #86. HOLD merge. Off #7. No RC5.