feat(ChangelogDialog): add modalClassName prop - #405
Merged
Conversation
The `--gc-changelog-dialog-*` variables are read by the modal, which is rendered in a portal above the element `className` is applied to, so they could only be set globally. `modalClassName` gives a per-instance way to set them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Preview is ready. |
amje
approved these changes
Aug 20, 2026
Set `--g-modal-max-width` on the modal via `modalClassName` instead of going through a component-specific alias. The deprecated `--gc-changelog-dialog-width` keeps working. `--gc-changelog-dialog-max-width` has not been released yet, so nothing in a published version depends on it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Lunory
force-pushed
the
fix/changelog-dialog-modal-class
branch
from
August 20, 2026 11:55
d4a5b7a to
7879ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--gc-changelog-dialog-*variables are read by the modal, which is rendered in a portal above the elementclassNameis applied to, so they could only be set globally.modalClassNamegives a per-instance way to set them.