Support syn 3.0#570
Merged
Merged
Conversation
Member
|
Sounds good to me. Ideally we'd check that everything compiles with both versions of syn in CI, but I don't have the bandwidth to do that myself. A contribution there would be very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the
synrequirement to>=2.0, <4so consumers already onsyn3 can unify the graph. Requirement only, no lockfile bump:syn3.0 needs Rust 1.71 and this crate advertises 1.66, so the committed lock stays onsyn2. Refs #569.The Rustfmt check failure looks pre-existing and unrelated: it flags a
__TypeKindimport order ingraphql_client_codegen/src/schema/json_conversion.rs, a file this PR does not touch.mainis red on the same job.