chore(generator): clean up universe import - #17966
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the unit tests in test_compat.py (and its template) across multiple generated packages. It replaces the aliased import of the _compat module (previously imported as universe) with direct imports of get_universe_domain, get_api_endpoint, and get_default_mtls_endpoint. It also imports EmptyUniverseError directly from google.api_core.universe and updates all test assertions to use these direct imports. I have no feedback to provide as there are no review comments and the changes are clean and consistent.
hebaalazzeh
marked this pull request as ready for review
July 31, 2026 22:20
ohmayr
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up universe import in
_compat.py.j2