[opt] Fix CanonicalizePass clamping: create Literal from known bits if dne#4575
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[opt] Fix CanonicalizePass clamping: create Literal from known bits if dne#4575copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_947784218
branch
from
July 14, 2026 20:33
a263faa to
c6e46f9
Compare
…f dne If the clamped value was not a Literal but was known, MaybeCanonicalizeClamp previously assumed it was a Literal and crashed. Now we construct a Literal from the Bits returned by the query engine. PiperOrigin-RevId: 947784218
copybara-service
Bot
force-pushed
the
test_947784218
branch
from
July 16, 2026 20:05
c6e46f9 to
53c8f46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[opt] Fix CanonicalizePass clamping: create Literal from known bits if dne
If the clamped value was not a Literal but was known, MaybeCanonicalizeClamp previously assumed it was a Literal and crashed. Now we construct a Literal from the Bits returned by the query engine.