Skip to content

[opt] Remove unnecessary vector copy in BddQueryEngine #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 20, 2026
+5 −9
Merged

[opt] Remove unnecessary vector copy in BddQueryEngine #4572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions xls/passes/bdd_query_engine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,16 +670,12 @@ std::unique_ptr<QueryEngine> BddQueryEngine::SpecializeGiven(
value_knowledge.intervals->AsView(),
[&](Type*, const IntervalSet& intervals,
absl::Span<const int64_t> tree_index) -> absl::Status {
std::vector<SaturatingBddNodeIndex> bits;
bits.reserve(intervals.BitCount());
for (int64_t i = 0; i < intervals.BitCount(); ++i) {
std::optional<BddNodeIndex> bit =
GetBddNode(TreeBitLocation(node, i, tree_index));
if (!bit.has_value()) {
return absl::OkStatus();
}
bits.push_back(*bit);
std::optional<SharedBddTree> info = GetInfo(node);
if (!info.has_value()) {
return absl::OkStatus();
}
absl::Span<const SaturatingBddNodeIndex> bits =
info->Get(tree_index);

SaturatingBddNodeVector in_interval_checks;
for (const Interval& interval : intervals.Intervals()) {
Expand Down
Loading