Skip to content

Fix SL_ANDROID_PERFORMANCE_LATENCY_EFFECTS not usable on OpenSL ES streams #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootkiller6788 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

Fix SL_ANDROID_PERFORMANCE_LATENCY_EFFECTS not usable on OpenSL ES streams #2411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/opensles/AudioStreamOpenSLES.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@ using namespace oboe;

AudioStreamOpenSLES::AudioStreamOpenSLES(const AudioStreamBuilder &builder)
: AudioStreamBuffered(builder) {
// OpenSL ES does not support device IDs. So overwrite value from builder.
mDeviceIds.clear();
// OpenSL ES does not support session IDs. So overwrite value from builder.
mSessionId = SessionId::None;
// Device ID and session ID are deliberately not reset here. They are read from the
// builder during open() to configure the stream, e.g. to select the performance mode,
// and to log unsupported attributes. They are reset in finishCommonOpen().
}

static constexpr int32_t kHighLatencyBufferSizeMillis = 20; // typical Android period
Expand Down Expand Up @@ -114,6 +113,13 @@ SLresult AudioStreamOpenSLES::finishCommonOpen(SLAndroidConfigurationItf configI
// Spatialization Behavior is not supported for OpenSL ES.
mSpatializationBehavior = SpatializationBehavior::Never;

// Device ID and session ID are not supported for OpenSL ES. They are only used during
// open() to configure the stream and to log unsupported attributes, so they are reset
// here once the stream has been configured. This also keeps getDeviceId() and
// getSessionId() from reporting attributes that OpenSL ES does not actually provide.
mDeviceIds.clear();
mSessionId = SessionId::None;

SLresult result = registerBufferQueueCallback();
if (SL_RESULT_SUCCESS != result) {
return result;
Expand Down