Fix: OpenAI o-series and gpt-3.5 model IDs route to no provider - #510
Open
Karthick-dev-cart wants to merge 2 commits into
Open
Fix: OpenAI o-series and gpt-3.5 model IDs route to no provider#510Karthick-dev-cart wants to merge 2 commits into
Karthick-dev-cart wants to merge 2 commits into
Conversation
Fixes google#492 OPENAI_PATTERNS only matched gpt-4/gpt-5 prefixes, so any o-series reasoning model (o1, o3, o4-mini, ...) or a legacy gpt-3.5 model id raised InferenceConfigError instead of routing to the OpenAI provider. Adds the two missing patterns and a regression test.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
|
Your branch is 1 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
…-series-gpt35-routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #492
Bug fix
OPENAI_PATTERNSinlangextract/providers/patterns.pyonly matchedgpt-4/gpt4./gpt-5/gpt5.prefixes. Any OpenAI o-series reasoning model id (o1,o3,o3-mini,o4-mini, ...) or a legacygpt-3.5-turbo-style id matched no provider pattern at all, sofactory.create_model()raisedInferenceConfigError: no provider foundinstead of routing to the OpenAI provider. Adds the two missing patterns (^gpt-3\.5,^o[1-9]).How Has This Been Tested?
Added
tests/patterns_test.pywith two tests:test_reasoning_and_legacy_openai_models_resolve_to_openai_provider-- verifies o-series (o1,o1-mini,o3,o3-mini,o4-mini) andgpt-3.5-turboall resolve to the OpenAI provider via the router, as subtests.test_ollama_gpt_oss_pattern_is_unaffected-- guards against the newo[1-9]pattern accidentally shadowing Ollama's existinggpt-ossmodel support.Checklist:
pylintover the affected code.