layout: don't insert layout rectification for func ops and generics - #3312
Open
copybara-service[bot] wants to merge 1 commit into
Open
layout: don't insert layout rectification for func ops and generics#3312copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When there are multiple secret return values, don't require the operands to have the same layout. This was happening before and causing the return operands to be layout converted to "compatible" layouts. This isn't required, so skip layout rectification for return, func, generic, and yield ops PiperOrigin-RevId: 960324740
copybara-service
Bot
force-pushed
the
test_960324740
branch
from
August 6, 2026 15:53
6a10e25 to
5eb11e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layout: don't insert layout rectification for func ops and generics
When there are multiple secret return values, don't require the operands to have the same layout. This was happening before and causing the return operands to be layout converted to "compatible" layouts. This isn't required, so skip layout rectification for return, func, generic, and yield ops