Skip to content

Fix aliasing bug in OpenFHE emitter for InsertOp with shared buffers #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toprakmurat wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −4
Open

Fix aliasing bug in OpenFHE emitter for InsertOp with shared buffers #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions lib/Target/OpenFhePke/OpenFhePkeEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,11 +1707,19 @@ LogicalResult OpenFhePkeEmitter::printOperation(

LogicalResult OpenFhePkeEmitter::printOperation(tensor::InsertOp op) {
// For a tensor.insert MLIR statement, we assign the destination vector and
// then map the result value to the destination value.
// then map the result value to the destination value if they are equal.
// %result = tensor.insert %scalar into %dest[%idx]
// dest[idx] = scalar;
os << variableNames->getNameForValue(op.getDest());
os << "[";
std::string destName = variableNames->getNameForValue(op.getDest());
std::string resultName = variableNames->getNameForValue(op.getResult());
if (destName != resultName) {
if (failed(emitType(op.getResult().getType(), op->getLoc()))) {
return failure();
}
os << " " << resultName << "(" << destName << ");\n";
}

os << resultName << "[";
if (op.getIndices().empty()) {
os << "0";
} else {
Expand All @@ -1724,7 +1732,10 @@ LogicalResult OpenFhePkeEmitter::printOperation(tensor::InsertOp op) {
os << "]";
os << " = " << variableNames->getNameForValue(op.getScalar()) << ";\n";

variableNames->mapValueNameToValue(op.getResult(), op.getDest());
if (destName == resultName) {
variableNames->mapValueNameToValue(op.getResult(), op.getDest());
}

return success();
}

Expand Down
25 changes: 25 additions & 0 deletions tests/Emitter/Openfhe/emit_insert_copy.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// RUN: heir-translate %s --emit-openfhe-pke | FileCheck %s

!cc = !openfhe.crypto_context
!ct = !openfhe.ciphertext

module attributes {scheme.bgv} {
// Two tensor.insert ops sharing the same tensor.empty buffer must produce
// distinct C++ vectors (copy-on-write), not alias both results to the same
// destination variable.

// CHECK: mm_bug_two_wraps
// CHECK: std::vector<{{.*}}> [[V1:v[0-9]+]](
// CHECK: [[V1]][0] = %arg1
// CHECK: std::vector<{{.*}}> [[V2:v[0-9]+]](
// CHECK: [[V2]][0] = %arg2
// CHECK: return {[[V1]], [[V2]]};
func.func @mm_bug_two_wraps(%arg0: !cc, %arg1: !ct, %arg2: !ct)
-> (tensor<1x!ct>, tensor<1x!ct>) {
%c0 = arith.constant 0 : index
%buf = tensor.empty() : tensor<1x!ct>
%wrap1 = tensor.insert %arg1 into %buf[%c0] : tensor<1x!ct>
%wrap2 = tensor.insert %arg2 into %buf[%c0] : tensor<1x!ct>
return %wrap1, %wrap2 : tensor<1x!ct>, tensor<1x!ct>
}
}
Loading