Nftables: Avoid race condition between update and evaluation. - #13898
Open
copybara-service[bot] wants to merge 1 commit into
Open
Nftables: Avoid race condition between update and evaluation.#13898copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
- There was no lock taken for Nftables rule evaluation.
So, it could happen that while processing and simultaneous update,
a packet could pass to half updated ruleset.
- Changed logic to replace atomic pointer, instead of
replacing fields in the Nftables.
- All the rule evaluation, can now go without needing any reader lock.
- A lock is require for updating Nftables object though,
to serialize the Netlink messages.
PiperOrigin-RevId: 955981065
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nftables: Avoid race condition between update and evaluation.
There was no lock taken for Nftables rule evaluation.
So, it could happen that while processing and simultaneous update,
a packet could pass to half updated ruleset.
Changed logic to replace atomic pointer, instead of
replacing fields in the Nftables.
All the rule evaluation, can now go without needing any reader lock.
A lock is require for updating Nftables object though,
to serialize the Netlink messages.