Fix unreachable code warning and unsafe sleep in rlimits test - #13895
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix unreachable code warning and unsafe sleep in rlimits test#13895copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl955675939
branch
7 times, most recently
from
July 31, 2026 00:57
70ad605 to
c8fdd07
Compare
The fork() loop in RLIMIT_NPROC tests previously used an infinite
while(1) { sleep(1); } loop followed by an unreachable _exit(1).
This caused a -Wunreachable-code warning. Additionally, invoking
sleep() immediately after a bare fork() can occasionally hang
when test frameworks are run with memory interceptors like TSan.
PiperOrigin-RevId: 955675939
copybara-service
Bot
force-pushed
the
test/cl955675939
branch
from
July 31, 2026 01:17
c8fdd07 to
c636cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unreachable code warning and unsafe sleep in rlimits test
The fork() loop in RLIMIT_NPROC tests previously used an infinite
while(1) { sleep(1); } loop followed by an unreachable _exit(1).
This caused a -Wunreachable-code warning. Additionally, invoking
sleep() immediately after a bare fork() can occasionally hang
when test frameworks are run with memory interceptors like TSan.