Deliver hangup events to blocked pollers on unix socket shutdown - #13894
Open
copybara-service[bot] wants to merge 1 commit into
Open
Deliver hangup events to blocked pollers on unix socket shutdown#13894copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The shutdown notification paths only notified ReadableEvents and WritableEvents, so a poller waiting only for POLLHUP or POLLRDHUP was never woken and slept until its timeout. Linux wakes all waiters via sk_state_change(). Notifications now include EventRdHUp and EventHUp where the closed direction can newly satisfy them; over-notifying is harmless since woken waiters re-check readiness. FUTURE_COPYBARA_INTEGRATE_REVIEW=#13887 from relkochta:relkochta/make-clangd-work 473e11a PiperOrigin-RevId: 955613879
copybara-service
Bot
force-pushed
the
test/cl955613879
branch
from
July 29, 2026 04:30
299436b to
0b5469e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliver hangup events to blocked pollers on unix socket shutdown
The shutdown notification paths only notified ReadableEvents and
WritableEvents, so a poller waiting only for POLLHUP or POLLRDHUP was
never woken and slept until its timeout. Linux wakes all waiters via
sk_state_change(). Notifications now include EventRdHUp and EventHUp
where the closed direction can newly satisfy them; over-notifying is
harmless since woken waiters re-check readiness.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13887 from relkochta:relkochta/make-clangd-work 473e11a