Fix bug in DaggerSuperficialValidation.validateTypeHierarchy(). - #5228
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_952556309
branch
5 times, most recently
from
July 27, 2026 19:28
43114d5 to
978cf49
Compare
In Javac, `Types.directSupertypes()` does not include error types. This causes `DaggerSuperficialValidation.validateTypeHierarchy()` to think the hierarchy is valid even when there are actually error types. To fix this, I've added validation of `TypeElement.getSuperClass()` and `TypeElement.getSuperInterfaces()` since those contain the error type in Javac. RELNOTES=N/A PiperOrigin-RevId: 954780872
copybara-service
Bot
force-pushed
the
test_952556309
branch
from
July 27, 2026 19:54
978cf49 to
3ed0a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in DaggerSuperficialValidation.validateTypeHierarchy().
In Javac,
Types.directSupertypes()does not include error types. This causesDaggerSuperficialValidation.validateTypeHierarchy()to think the hierarchy is valid even when there are actually error types.To fix this, I've added validation of
TypeElement.getSuperClass()andTypeElement.getSuperInterfaces()since those contain the error type in Javac.RELNOTES=N/A