Skip to content

[containerd-cri]Set HasFilesystem to true #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vasireddy99 wants to merge 2 commits into from
Closed

[containerd-cri]Set HasFilesystem to true #3253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7448235
Set HasFilesystem to true
vasireddy99 Feb 22, 2023
e0739fd
Remove comment
vasireddy99 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion container/containerd/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ func (h *containerdContainerHandler) needNet() bool {
func (h *containerdContainerHandler) GetSpec() (info.ContainerSpec, error) {
// TODO: Since we dont collect disk usage stats for containerd, we set hasFilesystem
Comment thread
vasireddy99 marked this conversation as resolved.
Outdated
// to false. Revisit when we support disk usage stats for containerd
Comment thread
vasireddy99 marked this conversation as resolved.
Outdated
hasFilesystem := false
hasFilesystem := true
spec, err := common.GetSpec(h.cgroupPaths, h.machineInfoFactory, h.needNet(), hasFilesystem)
spec.Labels = h.labels
spec.Envs = h.envs
Expand Down