Don't trigger neighbor list warnings on ignored constant keys that are actually present#1121
Merged
Conversation
Fix errant warning if ignoring constant param Ensure that constant parameters don't end up in the neighborlist
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 21 21
Lines 3632 3633 +1
=====================================
- Misses 3632 3633 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bdice
approved these changes
Jul 2, 2026
bdice
left a comment
bdice
left a comment
Member
There was a problem hiding this comment.
Approving with a couple ideas. I don't need to review further.
| assert neighbor_list[job.id] == {} | ||
|
|
||
| def test_neighborlist_structure(self): | ||
|
|
| assert key | ||
|
|
||
| def test_neighborlist_structure_with_constant(self): | ||
|
|
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an errant warning that would appear when ignoring a constant parameter.
Neighbor list calculation filtered out constant state point parameters, but then purposefully ignoring such a parameter would trigger a warning that the ignored key was not present. This adds tests for the structure of the neighbor list while fixing this.
Motivation and Context
Discovered while working on glotzerlab/signac-dashboard#320
Checklist: