Implement a subset of signac#359
Draft
joaander wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement a minimal subset of signac's functionality in Rust. Organize the code so that more functionality can be added over time as needed.
Motivation and context
It would be convenient if the entire simulation workflow from initialization to analysis could be performed in Rust. Currently, users need Python to initialize a signac workspace for use with row and hoomd-rs.
This pull requests implements a minimal set of functionality so that the initialization and job state point parsing can be handled in Rust. Specifically, it implements:
Compatibility is maintained so that any job written by the Rust implementation is valid in the Python implementation and any job written by the Python implementation is valid in Rust. The latter may not be convenient, but it should be possible. In highly heterogeneous workspaces, users will need to parse state points as
serde_json::Value.The Rust implementation will follow ideas currently under consideration for signac 3.0, such as immutable state points (glotzerlab/signac#983), and workspaces that include only job directories.
Open questions
ProjectandJobnames?Jobis especially confusing because a signac job is not at all related to a SLURM job. What would we call it?How has this been tested?
Checklist:
doc/src/credits.md) in the pull request source branch.release-notes.mdfollowing the established format.