Generalize GenerateGhosts for Periodic<Hypercuboid<_>> on N#338
Draft
janbridley wants to merge 8 commits into
Draft
Generalize GenerateGhosts for Periodic<Hypercuboid<_>> on N#338janbridley wants to merge 8 commits into
GenerateGhosts for Periodic<Hypercuboid<_>> on N#338janbridley wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous code used a fixed list of checks for N=2 and 3 when generating ghosts across a periodic cubic boundary. This change builds up the required list of checks for general dimension, using a bitset to avoid keeping too much data in memory. The result is comparable performance to the original code, but a dimension-agnostic approach. HOWEVER: this changes the ordering of neighbors, which does not appear to have performance or correctness implications but I could be wrong on that.
Motivation and context
How has this been tested?
Regression tests against the old code
Checklist:
doc/src/credits.md) in the pull request source branch.release-notes.mdfollowing the established format.