[log] Add debug logging to BaseResponseWriter#8616
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…iter.go Add logHTTP debug calls to WriteHeader and Write methods of BaseResponseWriter to trace HTTP status code capture behaviour: - Log when a status code is first captured by WriteHeader - Log when a duplicate WriteHeader call is ignored (with already-captured code) - Log when Write implicitly captures a 200 status on first write Uses the existing logHTTP logger declared in httputil.go (no new declaration needed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds meaningful debug logging calls to
internal/httputil/response_writer.gousing the existinglogHTTPlogger (declared inhttputil.go).Changes
File:
internal/httputil/response_writer.goAdded 3
logHTTP.Printfcalls toBaseResponseWriter:WriteHeader— first call: logs the status code being capturedWriteHeader— duplicate call: logs when a subsequentWriteHeaderis ignored, showing both the new and already-captured codesWrite— implicit 200: logs whenWritetriggers an implicit200 OKcapture, including payload lengthThese log calls help trace HTTP response status flows during debugging, especially when investigating unexpected status codes or duplicate header writes.
Notes
logHTTPfromhttputil.gogo test ./internal/httputil/...andgo vet ./internal/httputil/...passgo buildsucceedsWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.