[core] Make RenderBundleEncoder use Arced resources#9830
Conversation
c7c0846 to
c4e7c2d
Compare
teoxoy
left a comment
There was a problem hiding this comment.
Looks great but I think this needs to wait on https://bugzilla.mozilla.org/show_bug.cgi?id=2052197 (which I will put up a patch for in a bit).
|
Or at last for #9832 in case the wgpu update gets backed out again. |
|
I just put up the patches for https://bugzilla.mozilla.org/show_bug.cgi?id=2052197. We should probably still wait for those to land first or else we won't be able to easily do the next wgpu update. |
|
I reviewed patches in bug 2052197. Only minor feedback given, which I'd expect to be cleared up pretty fast. |
|
Stuff in mozilla has landed so I rebased and resolved conflicts. Should we wait some time to make sure change is not backed out? CI miri failure will be solved by katharostech/cfg_aliases#15, though we should probably use pinned nightly and let renovate do the bump. |
The likely backout window has passed, so no need to wait for that. Teo may have already done this, but it couldn't hurt to build Firefox with this change to make sure there aren't any unexpected surprises. I ought to be able to do that today. |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Connections
Towards #5121
Fixes #8234
Description
This was not as hard as I imagined. We firstly remove bundle_ffi, then we replace
parent_id: DeviceIdwithArc<Device>(with this we remove ser/de and we always do validation on creation - as we always have device) and lastly we make all resources Arced. For the cherry on top we make make Global methods of RenderBundleEncoder thin.Testing
Should be covered by existing tests.
Squash or Rebase?
Rebase
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.