Skip to content

Use the same method to get url in all spring filters#5656

Draft
lbloder wants to merge 10 commits into
mainfrom
fix/spring-urls
Draft

Use the same method to get url in all spring filters#5656
lbloder wants to merge 10 commits into
mainfrom
fix/spring-urls

Conversation

@lbloder

@lbloder lbloder commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Use the same method to get url in all spring filters ([#5656](https://github.com/getsentry/sentry-java/pull/5656))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 512dd07

@sentry

sentry Bot commented Jun 29, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.47.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 315.67 ms 347.13 ms 31.46 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d364ace 382.77 ms 443.21 ms 60.44 ms
4c04bb8 333.16 ms 408.16 ms 75.00 ms
bb0ff41 344.70 ms 413.82 ms 69.12 ms
91bb874 314.47 ms 440.00 ms 125.53 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms
8687935 294.00 ms 304.02 ms 10.02 ms
eb95ded 317.51 ms 369.08 ms 51.57 ms
b936425 302.69 ms 372.86 ms 70.17 ms
d15471f 342.08 ms 415.44 ms 73.35 ms
5b66efd 308.67 ms 363.85 ms 55.18 ms

App size

Revision Plain With Sentry Diff
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
4c04bb8 0 B 0 B 0 B
bb0ff41 0 B 0 B 0 B
91bb874 1.58 MiB 2.13 MiB 559.07 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB
8687935 1.58 MiB 2.19 MiB 619.17 KiB
eb95ded 0 B 0 B 0 B
b936425 0 B 0 B 0 B
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
5b66efd 1.58 MiB 2.13 MiB 559.07 KiB

Previous results on branch: fix/spring-urls

Startup times

Revision Plain With Sentry Diff
2250e97 363.21 ms 421.44 ms 58.23 ms

App size

Revision Plain With Sentry Diff
2250e97 0 B 0 B 0 B

@lbloder lbloder changed the title UIse the same method to get url in all spring filters Use the same method to get url in all spring filters Jun 29, 2026
span.setDescription(method + " " + request.url());
span.setDescription(method + " " + urlDetails.getUrlOrFallback());
span.setData(SpanDataConvention.HTTP_METHOD_KEY, method.toUpperCase(Locale.ROOT));
urlDetails.applyToSpan(span);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to own issue, release in major

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • sentry/src/main/java/io/sentry/transport/HttpConnection.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants