ci: add build verification and server tests - #1139
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds server test commands and output-validation coverage, then introduces a GitHub Actions workflow that runs tests and builds the server, ChangesCI and server validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 24-25: Update the actions/checkout@v4 step to disable credential
persistence by configuring its persist-credentials input as false; leave the
rest of the workflow unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 45551ee5-f358-4890-9f3e-e4cc4bb10f3b
📒 Files selected for processing (3)
.github/workflows/ci.ymlpackage.jsontests/server/utils/output-validation.test.js
This workflow only reads the repository. Program does not need token, so don't leave it in .git/config.
|
I took CodeRabbit's suggestions. I hardened the workflow / checkout step (persist-credentials: false). Local validation passes. Since this is the initial CI/testbasline for this project, I am happy to adjust the flow and workflow shape if the maintainers prefer a different direction. |
Summary
developnpm test/npm run test:serverscriptsmaxun-corein CI so changes under the local core package get coverage tooWhy
The repository currently does not have a first party CI workflow or test suite. This starts with a small baseline so future PRs can get automatic install, build, and test feedback without introducing a larger test framework decision yet.
The first test target is intentionally narrow:
output-validationis pure server logic and does not require browser, database, MinIO, or Docker setup.Notes
npm ci --legacy-peer-deps, matching the existing Dockerfile install convention.npm run lintcurrently points at./node_modules/.bin/eslint, buteslintis not listed in the root package manifest.maxun-corebuild step because the backend currently consumesmaxun-corefrom npm, while this repository also contains localmaxun-coresource.Questions for maintainers
Is this kind of small CI/test baseline be welcome as a foundation? If there are constraints around CI runtime, test framework preference, or how
maxun-corechanges should be validated from this repo, I am happy to adjust the approach.Validation
npm testnpm ci --prefix maxun-core && npm run build --prefix maxun-corenpm run buildgit diff --checkSummary by CodeRabbit
Tests
Chores