ExperimentsOverview: drop Cumulative hint from goodput queries

[reflog]

What

Drop the temporality: "Cumulative" hint from the proxy.session.goodput.* queries.

Part of getlantern/engineering#3831. Companion PRs: getlantern/lantern-cloud#3194, getlantern/http-proxy#683, getlantern/lantern-box#302.

Why

The goodput histogram becomes delta temporality in that work, so the ops collector can aggregate away route.id/instance.id/host.name — the histogram had reached ~55M unique series (host.name alone has 10,854 distinct values on it) and was timing out every SigNoz query past a ~1 week window.

The mean-goodput math here is unaffected either way: avgGoodputByTrack computes rate(sum)/rate(count), and the rate window cancels in the ratio.

But the hint itself is not a no-op. v4 returns no series at all for rate() over a stream whose temporality does not match the hint — which is why it was added in the first place. Left in place, the goodput cards would silently go blank once the emitters roll. Delta is the API default, so the hint is simply removed.

Testing

npm run build (tsc -b + vite) passes clean.

Ordering

Safe to merge alongside the emitter PRs. Before they roll the hint is stale-but-harmless in this direction only if the emitters are already delta, so land this with them rather than well ahead.

/cc @jay-418 @Crosse

Summary by CodeRabbit

• Bug Fixes
  • Corrected goodput metric handling to use the appropriate delta-based interpretation.
  • Improved experiment dashboard metric queries for more accurate results.
• Documentation
  • Updated metric-temporality documentation to clarify how cumulative and delta metrics are handled.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b666ab0-3979-4c5e-913e-3a621798c40a

📥 Commits

Reviewing files that changed from the base of the PR and between c420f90 and e54ca30.

📒 Files selected for processing (2)

• src/api/client.ts
• src/components/ExperimentsOverview.tsx

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The changes classify dashboard metrics as delta streams and remove the explicit cumulative temporality from the goodput query. The query now relies on the API default temporality for v4 series retrieval.

Changes

Metrics temporality

Layer / File(s)	Summary
Goodput query temporality src/api/client.ts, src/components/ExperimentsOverview.tsx	The client comments classify proxy, bandit, and goodput metrics as delta metrics. The goodput query removes its explicit cumulative temporality setting and uses the API default.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e54ca

This localized query change removes an outdated temporality hint so goodput metrics continue to populate after emitters switch to delta temporality. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the cumulative temporality hint from goodput queries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 3831-goodput-delta

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Updates the experiments dashboard’s SigNoz builder queries for proxy.session.goodput.* to stop forcing "Cumulative" temporality, aligning the UI with the planned switch of the goodput histogram streams to delta temporality (per getlantern/engineering#3831) so the charts don’t go blank once emitters roll.

Changes:

• Removed the temporality: "Cumulative" hint from the goodput sum/count queries used to compute mean per-session goodput.
• Updated inline documentation to clarify when a temporality hint is needed and why it must match the underlying stream temporality.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/components/ExperimentsOverview.tsx	Drops the "Cumulative" temporality hint from goodput queries and updates comments explaining why.
src/api/client.ts	Refines documentation for buildExperimentTrackQuery’s optional temporality and notes goodput now being delta per #3831.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.