Place scroll hint markers near scrollbar edges - #1437
Open
LwhJesse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts link hint marker placement for scrollable targets.
For scrollY hints, the marker is placed near the right edge of the visible scrollable area. For scrollX hints, the marker is placed near the bottom edge. Other hint types keep the existing placement behavior.
This makes scroll-only hint mappings easier to understand visually, because markers appear near the corresponding scrollbar instead of the element's top-left corner.
Tested locally by loading the built extension unpacked in Chrome and using a scroll-only mapping:
map ;s LinkHints.activateModeToFocus typeFilter=768
Verified vertical scroll containers and horizontal scroll containers show markers near their scrollbar edges.