Skip to content

fix: allow extension IDs to start with { for *Firefox* #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenxxiu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow extension IDs to start with { for *Firefox* #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion background/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ Object.assign<typeof updateHooks_, { [key in SettingsNS.DeclaredUpdateHooks]: Se
const map = extAllowList_
map.forEach((v, k): void => { v !== false && map.delete(k) })
if (!val) { return; }
for (let arr = val.split("\n"), i = arr.length, wordCharRe = /^[\da-z_]/i as RegExpI; 0 <= --i; ) {
for (let arr = val.split("\n"), i = arr.length, wordCharRe = /^[\da-z_{]/i as RegExpI; 0 <= --i; ) {
if ((val = arr[i].trim()) && wordCharRe.test(val)) {
map.set(val, true)
}
Expand Down
7 changes: 3 additions & 4 deletions pages/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,10 +716,9 @@
</td>
<td class="help"><div class="help-inner">
<div data-i="92">Only extensions in this list are allowed to request Vimium C's support.
One extension id per line.</div>
<span data-i="93">Any line the first char of which is neither a letter nor a number or
"</span><kbd>_</kbd><span data-i="94">" will be ignored</span><span
data-i="period">.</span><span data-i="NS">
One extension ID per line.</div>
<span data-i="93">Valid extension IDs have to start with the regex <kbd>[\da-z_{]</kbd>
<span data-i="94"></span><span data-i="period">.</span><span data-i="NS">
</span><a class="wrap-left-space" data-auto-resize="extAllowList" role="button" tabindex="0"
data-i="autoResize">Auto resize</a><span data-i="period">.</span><br>
<a href="#" data-vim-url="vimium://wiki/Inject-into-other-extensions" data-i="95">
Expand Down