Skip to content

Added observability events and reviewed docs and code. - #59

Merged
lextatic merged 6 commits into
mainfrom
feature/observability-seams
Aug 4, 2026
Merged

Added observability events and reviewed docs and code.#59
lextatic merged 6 commits into
mainfrom
feature/observability-seams

Conversation

@lextatic

@lextatic lextatic commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Added

  • Added events for better Abilities observability.
  • Added events for better Effects observability.
  • Added tests for Tags observability events.

Changed

  • Renamed ConcatenateResolver.
  • Reviewed existing docs.

@lextatic lextatic added the added New features label Aug 4, 2026
@lextatic
lextatic requested a lite review from Copilot August 4, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds manager-level change-notification events for effects, abilities, and tags to improve observability (UI/analytics/combat logs), updates documentation to explain the new notifications and Statescript concepts, and renames the quaternion concatenate resolver for clarity.

Changes:

  • Introduced new effects lifecycle notifications on EffectsManager (applied/executed/added/changed/removed/stack-denied) and ability lifecycle notifications on EntityAbilities (granted/changed/removed/activated/activation-failed).
  • Made tag changes externally observable via EntityTags.OnTagsChanged and added new test coverage for tags/effects/abilities notification behavior.
  • Renamed ConcatenateResolver to QuaternionConcatenateResolver and updated related docs/tests.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Tightens/condenses project description wording.
Forge/Statescript/Properties/QuaternionConcatenateResolver.cs Renames resolver type and updates exception message accordingly.
Forge/Effects/EffectsManager.cs Adds effect lifecycle notification events and invokes them throughout the pipeline.
Forge/Core/EntityTags.cs Exposes OnTagsChanged publicly with clarified lifecycle remarks.
Forge/Core/EntityAbilities.cs Adds ability lifecycle notification events and makes GrantedAbilities read-only to external callers.
Forge/Abilities/Ability.cs Emits activation-failure and activation-start notifications via EntityAbilities.
Forge.Tests/Tags/EntityTagsEventTests.cs Adds tests for EntityTags.OnTagsChanged semantics.
Forge.Tests/Statescript/Resolvers/QuaternionConcatenateResolverTests.cs Updates resolver tests to use the renamed class.
Forge.Tests/Effects/EffectsManagerEventsTests.cs Adds tests validating effect notification sequencing and payloads.
Forge.Tests/Abilities/EntityAbilitiesEventsTests.cs Adds tests validating ability notification sequencing and payloads.
docs/tags.md Documents reacting to tag changes via OnTagsChanged.
docs/statescript/resolvers/README.md Updates resolver index entry for renamed quaternion concatenate resolver.
docs/statescript/resolvers/quaternion-concatenate-resolver.md Renames and clarifies quaternion concatenate resolver documentation.
docs/statescript/resolvers/conjugate-resolver.md Updates examples/links to renamed resolver.
docs/statescript/custom-resolvers.md Adds guidance for implementing object-lane resolvers.
docs/README.md Tweaks link text for main README reference.
docs/quick-start.md Adds a Statescript introduction and expands “next steps” links.
docs/effects/stacking.md Documents OnEffectStackDenied for stacking-driven denials.
docs/effects/README.md Documents effect change notifications and updates removal example.
docs/cues.md Clarifies cues vs Events system vs change notifications.
docs/abilities.md Documents ability change notifications and updates GrantedAbilities type/semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Forge/Effects/EffectsManager.cs
@lextatic
lextatic merged commit 8dd065b into main Aug 4, 2026
1 check passed
@lextatic
lextatic deleted the feature/observability-seams branch August 4, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants