fix(#6149): change DefaultUpstreamRef from v0 to main - #6565
fix(#6149): change DefaultUpstreamRef from v0 to main#6565fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
The code agent scaffold template was the only stage using @main while all other workflows used @v0, creating inconsistency. Per the team decision (meeting 2026-08-18), standardize all scaffold workflow templates on main instead of v0 to ensure version consistency across all agent workflows. Changes: - Update DefaultUpstreamRef constant from "v0" to "main" in internal/config/config.go, which controls the ref used for all reusable workflow references rendered into scaffold templates - Replace hardcoded ref: v0 in repo-maintenance.yml with the __FULLSEND_AI_REF__ placeholder so it derives from the same constant as the mint-token action in the same file - Update tests to expect @main instead of @v0 Note: actionlint and pinact hooks could not run (not installed in sandbox). gofmt, go vet, and all targeted tests pass. Pre-commit hooks could not run due to sandbox network restrictions (git fetch blocked). Closes #6149
|
🤖 Finished Review · ✅ Success · Started 8:03 PM UTC · Completed 8:20 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.88 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Previous runReviewFindingsHigh
Medium
Low
Next steps:
|
|
🤖 Finished Fix · ✅ Success · Started 8:22 PM UTC · Completed 8:28 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.23 |
Update documentation examples that still referenced @v0 to use @main, matching the DefaultUpstreamRef change in internal/config/config.go. - docs/guides/user/building-custom-agents.md: checkout ref and install action - docs/guides/user/custom-poller-example.md: reusable dispatch workflow ref - docs/guides/user/jira-integration.md: reusable dispatch workflow ref - docs/guides/dev/testing-workflows.md: layered install description - docs/guides/dev/cli-internals.md: content category table and description Addresses review feedback on #6565
🔧 Fix agent — iteration 1 (bot-triggered)Fixed all 6 actionable review findings: updated stale @v0 references to @main in 5 documentation files (4 high, 2 medium). Recorded reasoned disagreements for 4 low-severity informational findings that the reviewer themselves noted required no action (accepted team decision, historical references, and release process refs). Fixed (6):
Disagreed (4):
Tests: passedNext steps:
|
Site previewPreview: https://c13f1085-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 8:30 PM UTC · Completed 8:44 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.40 |
Superseded by updated review
|
I think we need a new ADR to override what we decided at https://fullsend.sh/docs/ADRs/0048-automatic-updates.html#decision, there we decided to not track main by default to avoid breaking users, this is why we were tracking v0. With the change on this PR we are installed new users against |
Summary
Changes
DefaultUpstreamReffromv0tomainso all scaffold workflow templates use the same reusable workflow ref, resolving the inconsistency where the code agent was the only stage tracking@mainwhile all others were pinned to@v0. Also replaces a hardcodedref: v0inrepo-maintenance.ymlwith the__FULLSEND_AI_REF__placeholder for consistency.This implements the team decision from the 2026-08-18 meeting to standardize on
mainbranch tracking for version consistency across all agent workflows.Changes
internal/config/config.go: ChangeDefaultUpstreamRefconstant from"v0"to"main"internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml: Replace hardcodedref: v0withref: __FULLSEND_AI_REF__placeholderinternal/scaffold/render_test.go: Update test assertions from@v0to@maininternal/layers/workflows_test.go: Update pinned-SHA leak guard to check for@mainTesting
go test ./internal/config/...passesgo test ./internal/scaffold/...passesgo test ./internal/layers/...passesgo test ./internal/repos/...passesgofmtandgo vetpassCloses #6149
Post-script verification
agent/6149-scaffold-ref-to-main)7b08468970a4e9e924efff34aab5ec62b890b6ca..HEAD)