docs(#6543): replace stale 'sync' references with 'convergence' - #6544
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#6543): replace stale 'sync' references with 'convergence'#6544fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
PR #6498 replaced the Sync()/Diff() API with a unified Converge() call but missed two documentation files. Update both to use convergence terminology consistent with the already-updated infrastructure-reference.md: - cli-internals.md ASCII diagram: "not managed by sync" → "not managed by convergence", "managed by sync" → "managed by convergence" - building-custom-agents.md inline YAML comment: "not managed by sync" → "set at install time, updated during convergence" Verified: `grep -rn 'managed by sync' docs/` returns zero results after this change. Closes #6543
Site previewPreview: https://eb53c63a-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 12:21 AM UTC · Completed 12:29 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.43 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync.gowas deleteddocs/guides/dev/cli-internals.md: update ASCII diagram labels from "not managed by sync" / "managed by sync" to "not managed by convergence" / "managed by convergence"docs/guides/user/building-custom-agents.md: update inline YAML comment from "not managed by sync" to "set at install time, updated during convergence"Context
PR #6498 replaced
Sync()/Diff()with a unifiedConverge()call and updatedinfrastructure-reference.mdbut missed these two files. The review agent flagged both asstale-referencefindings on run 9. This PR completes the terminology migration.Testing
grep -rn 'managed by sync' docs/returns zero resultsgrep -rn 'sync\.go\|Sync()\|SyncResult' docs/returns only unrelated references (file sync in tracing.md, historical analysis in review-autonomy-evidence.md)Closes #6543
Post-script verification
agent/6543-fix-stale-sync-refs)fe5348b5c7e2852d49e06e47825fbec16393da88..HEAD)