docs(#6539): one local-run flow — pi is a --runtime flag on the standard examples - #6540
docs(#6539): one local-run flow — pi is a --runtime flag on the standard examples#6540waynesun09 wants to merge 4 commits into
Conversation
…ard examples The guide taught pi as a 350-line parallel walkthrough (hand-rolled pi-hello harness, own config/profile/policy) written before the runtime became a per-run choice (#6526) and before the fleet repo carried the pi plumbing (agents#965/#975). Now there is one flow: the standard fleet examples, plus a "Choosing the runtime" subsection with --runtime pi on the same commands, the override precedence table (both runtimes), the verbatim output of a verified run (fullsend main @ 89bf3b8 against agents main @ 299f264 on macOS and Fedora — harness-default values print bare, overrides carry their source), Gemini-on-Vertex selection by model name, and a compact pi-notes list (build the CLI from main until a release ships pi; image 0.37+ and the exit-127 preflight symptom; review/retro single-context; FULLSEND_PI_PROVIDER and the bash allowlist; fail-closed hooks; --debug='*' and pi-debug.log). The pi platform notes fold into the existing Platform notes as one bullet per OS, and docs/runtimes.md points at the new anchor. Closes #6539 Assisted-by: Claude (code) Signed-off-by: Wayne Sun <gsun@redhat.com>
PR Summary by QodoDocs: unify local-run guide; choose pi via --runtime on standard examples
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
🤖 Review · Commit: |
Site previewPreview: https://b804ae96-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…located troubleshooting The runtimes.md callout no longer promises a fleet-free walkthrough; the image requirement is stated as 'bakes PI_VERSION' instead of an unsourced 0.37+ tag; the operational knowledge from the deleted section (sandbox env via harness host_files not --env-file, export in .env.d, the disabled-provider symptom, the silent claude fallback and where to see it) lives in a pi subheading under Troubleshooting; the container path carries the same build-from-main caveat; the Gemini example is a full command; old anchors get HTML aliases; run-dir tree notes pi-debug.log; guides index no longer claims released binaries cover pi. Assisted-by: Claude (fix), Grok (review) Signed-off-by: Wayne Sun <gsun@redhat.com>
Code Review by Qodo
1.
|
Assisted-by: Claude (fix) Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 7:45 PM UTC · Completed 7:59 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $6.50 |
ReviewFindingsLow
Labels: PR modifies only documentation files under docs/ Previous runReviewFindingsLow
|
Assisted-by: Claude (fix) Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 8:03 PM UTC · Completed 8:19 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.26 |
| ``` | ||
|
|
||
| ### Choosing the runtime | ||
|
|
There was a problem hiding this comment.
[low] anchor misdirection
The HTML redirect anchors troubleshooting-pi-runtime and platform-notes-pi are co-located at the Choosing the runtime heading, but the actual troubleshooting content lives in the ### pi runtime subsection under Troubleshooting, and platform notes are inlined into macOS/Linux sections. A visitor following a bookmarked #troubleshooting-pi-runtime link lands at the runtime-selection section instead of the troubleshooting content.
Suggested fix: Move the troubleshooting-pi-runtime anchor to the ### pi runtime troubleshooting subsection and platform-notes-pi to one of the pi bullets in Platform notes.
| @@ -746,6 +479,26 @@ to the server (gateway). It is likely that you need to bind the gateway to `0.0. | |||
| **`unable to replace "host-gateway"` on macOS** | |||
There was a problem hiding this comment.
[low] heading-hierarchy-consistency
The new ### pi runtime heading under ## Troubleshooting introduces an H3 sub-heading that no other troubleshooting entry uses — all six existing entries use a flat bold title format directly under the H2. This creates a structural asymmetry in the section and affects the site outline/TOC.
Suggested fix: Either convert the pi troubleshooting entries to the existing flat bold title format, or convert all existing troubleshooting entries to grouped H3 sections.
|
Sounds like we need a runtime section with a page for each runtime with details about it. I think we need to keep the "running agents locally" basic and not mentioning |
Summary
Replaces the 350-line pi-specific walkthrough in
docs/guides/user/running-agents-locally.mdwith a single local-run flow: the existing fleet examples plus a "Choosing the runtime" subsection (--runtime pion the same commands, override precedence for both runtimes, Gemini-on-Vertex by model name, compact pi notes) and one pi bullet per OS in Platform notes.docs/runtimes.mdnow points at the new anchor. 890 → 604 lines; no code changes.The example output is verbatim from a verified run of fullsend
main@89bf3b8against fullsend-ai/agentsmain@299f264(macOS Apple Silicon and Fedora): harness-defaultModel:/Effort:print bare, overridden values carry(from …),metrics.jsonshowsruntime_sourceseparately fromoverride_source.review/retrowere re-confirmed schema-valid under--runtime pi(single-context, stated as such). The doc deliberately shows Gemini selection syntax without a success transcript (known model-behaviour items are tracked in #6527/#6535).Note: the code agent's run for #6539 ended with "no changed files", so this PR was authored directly by the human takeover session.
Review rounds
docs/runtimes.mdcallout still promised a "no fleet repo required" walkthrough (rewritten); MEDIUMs all applied: image requirement now referenced as v0.37.0+ (was an unsourced tag mix-up), the deleted section's operational knowledge relocated into a pi runtime Troubleshooting subheading (sandbox env via harnesshost_filesnot--env-fileper ADR 0055,exportneeded in.env.dfiles — re-verified againstrun.go's plain.sourcing loop — the disabled-provider symptom, the silent-Claude fallback and where the plan block shows it), the container path carries the same build-from-main caveat, HTML alias anchors keep the three old permalinks working, the Gemini example is a full command, run-dir tree notespi-debug.log, guides index no longer claims released binaries cover pi.withSourcebare-vs-annotated printing,FULLSEND_PI_PROVIDERdefault,FULLSEND_PI_BASH_ALLOWLIST=enforce, the#choosing-the-runtimeanchor.Related Issue
Closes #6539
Changes
docs/runtimes.md's local-run link to the new anchorTesting
make lintequivalents on changed files: docs-link lint, lychee, markdown checks via pre-commit — cleanChecklist
!for breaking changes)