Enforce signup priority correctness - #565
Open
georgelgeback wants to merge 3 commits into
Open
Conversation
hannesblaman
previously approved these changes
Aug 16, 2026
hannesblaman
left a comment
Contributor
There was a problem hiding this comment.
Realized that group system doesn't care about which year's nollning your group belongs to. Fixed accordingly.
Otherwise LGTM!
…ead of all groups in nollning
Contributor
|
On second thought, I reworked the get_user_nollning_priorities funtction to only loop through the groups that the user actually has. Should optimize with less unnecessary looping but keep the same functionality. If you are happy with that change then it LGTM. Re-approved! |
hannesblaman
self-requested a review
August 16, 2026 23:16
hannesblaman
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically this changes: