Enable PDF stream compression when optimize is enabled - #284
Open
ertankucukoglu wants to merge 1 commit into
Open
Enable PDF stream compression when optimize is enabled#284ertankucukoglu wants to merge 1 commit into
ertankucukoglu wants to merge 1 commit into
Conversation
Owner
|
Huh, I thought this was re-enabled, thanks. I'll merge it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
optimizeis enabled.optimizestill keeps streams uncompressed.Why
The save option said it would compress PDFs, but the compression call was disabled and font compression was blocked. This made generated PDF files larger than necessary.
Tests
cargo testcargo test --test stream_compression(4 passed)cargo test --features html --test external_tools --test font_embedding -- --nocapture(24 passed)