Skip to content

Fix Elastic adapter when attempting to generate notes for non-ApiError exceptions - #230

Open
JSCU-CNI wants to merge 2 commits into
fox-it:mainfrom
JSCU-CNI:elastic-notes
Open

Fix Elastic adapter when attempting to generate notes for non-ApiError exceptions#230
JSCU-CNI wants to merge 2 commits into
fox-it:mainfrom
JSCU-CNI:elastic-notes

Implement review suggestion

670fc41
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 31, 2026 in 1s

84.27% (-0.02%) compared to e6b58fd, passed because coverage increased by 0.02% when compared to adjusted base (84.24%)

View this Pull Request on Codecov

84.27% (-0.02%) compared to e6b58fd, passed because coverage increased by 0.02% when compared to adjusted base (84.24%)

Details

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.27%. Comparing base (e6b58fd) to head (670fc41).

Files with missing lines Patch % Lines
flow/record/adapter/elastic.py 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   84.29%   84.27%   -0.02%     
==========================================
  Files          35       35              
  Lines        3756     3758       +2     
==========================================
+ Hits         3166     3167       +1     
- Misses        590      591       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.