Skip to content

Fix VMDK descriptor encoding - #91

Open
dev-rehaann wants to merge 1 commit into
fox-it:mainfrom
dev-rehaann:fix/vmdk-descriptor-encoding
Open

Fix VMDK descriptor encoding#91
dev-rehaann wants to merge 1 commit into
fox-it:mainfrom
dev-rehaann:fix/vmdk-descriptor-encoding

Conversation

@dev-rehaann

Copy link
Copy Markdown

Summary

  • decode standalone and embedded VMDK descriptors using their declared encoding
  • retain best-effort UTF-8 parsing when an encoding is missing or unsupported
  • add a GBK regression test with a non-ASCII extent filename

Testing

  • pytest -q tests/disk/test_vmdk.py (16 passed)

uff check and
uff format --check

Fixes #90

Honor the encoding declared by standalone and embedded VMDK
descriptors so non-ASCII extent filenames remain intact.

Signed-off-by: Muhammad Rehan Khan <dev.rehaann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VmdkDisk fails to parse descriptor with non-UTF-8 encoding (e.g. GBK), causing mangled extent/disk filenames and FileNotFoundError

1 participant