add windows install script#6
Open
fivetran-pavlonikolenko wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Windows (PowerShell) installer to bootstrap and run the Fivetran Proxy Agent via Docker, aligning Windows installation with the existing Unix install.sh flow.
Changes:
- Introduces
install.ps1to validate Docker prerequisites and host resources on Windows. - Bootstraps agent configuration (copy from file or fetch via
/proxy-agent/configure) and pins the latest available agent version. - Downloads the Windows manager script, starts the agent container, and reports health/status.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
This review was generated by Claude (claude-sonnet-4-6) using a multi-agent workflow that ran independent finders across several correctness/security angles, then adversarially verified every candidate finding before reporting. 9 findings were CONFIRMED and 1 was marked PLAUSIBLE.
Two fixes needed before this is safe on a clean Windows machine:
- 1 (L230) — downloaded scripts get a Zone.Identifier ADS that blocks execution under the default
RemoteSignedpolicy; addUnblock-FileafterMove-Item. - 2 (L253) —
Invoke-RestMethodsilently succeeds on non-200 2xx responses and round-trips the JSON through PowerShell's object model; switch toInvoke-WebRequestwith an explicit 200 check and write.Contentverbatim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new Windows install script
Tested on a Windows machine:
Run the manager script to check the status: