Skip to content

add windows install script#6

Open
fivetran-pavlonikolenko wants to merge 5 commits into
mainfrom
windows-install-script
Open

add windows install script#6
fivetran-pavlonikolenko wants to merge 5 commits into
mainfrom
windows-install-script

Conversation

@fivetran-pavlonikolenko

@fivetran-pavlonikolenko fivetran-pavlonikolenko commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Adding new Windows install script

Tested on a Windows machine:

PS C:\Users\Pavlo> & C:\Users\Pavlo\proxy\install.ps1
Installing Fivetran Proxy Agent...

Checking prerequisites... OK

Downloading management script...
Fetching agent config from https://api-staging.fivetran.com...
Resolving latest proxy agent version...
Using version 1.2.3
Starting proxy-agent-oil_tinsel (version: 1.2.3)...
490f9ff1419bd9a71723fb4f572180cd5640a630a61b2c0c2c6ff3ecf0879d97
Waiting for proxy-agent-oil_tinsel to become healthy (timeout: 60s)...
NAMES                    IMAGE                                                                                 STATUS
proxy-agent-oil_tinsel   us-docker.pkg.dev/prod-eng-fivetran-public-repos/public-docker-us/proxy-agent:1.2.3   Up 5 seconds (healthy)
Success: proxy-agent-oil_tinsel is healthy.

Installation complete.
Install directory: C:\Users\Pavlo\fivetran-proxy-agent

Run the manager script to check the status:

PS C:\Users\Pavlo> $mgr = "$env:USERPROFILE\fivetran-proxy-agent\proxy-agent-manager.ps1"
PS C:\Users\Pavlo> & $mgr status
NAMES                    IMAGE                                                                                 STATUS
proxy-agent-oil_tinsel   us-docker.pkg.dev/prod-eng-fivetran-public-repos/public-docker-us/proxy-agent:1.2.3   Up 5 minutes (healthy)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Windows (PowerShell) installer to bootstrap and run the Fivetran Proxy Agent via Docker, aligning Windows installation with the existing Unix install.sh flow.

Changes:

  • Introduces install.ps1 to validate Docker prerequisites and host resources on Windows.
  • Bootstraps agent configuration (copy from file or fetch via /proxy-agent/configure) and pins the latest available agent version.
  • Downloads the Windows manager script, starts the agent container, and reports health/status.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread install.ps1
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated

@fivetran-paulharper fivetran-paulharper left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review was generated by Claude (claude-sonnet-4-6) using a multi-agent workflow that ran independent finders across several correctness/security angles, then adversarially verified every candidate finding before reporting. 9 findings were CONFIRMED and 1 was marked PLAUSIBLE.

Two fixes needed before this is safe on a clean Windows machine:

  • 1 (L230) — downloaded scripts get a Zone.Identifier ADS that blocks execution under the default RemoteSigned policy; add Unblock-File after Move-Item.
  • 2 (L253)Invoke-RestMethod silently succeeds on non-200 2xx responses and round-trips the JSON through PowerShell's object model; switch to Invoke-WebRequest with an explicit 200 check and write .Content verbatim.

Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Comment thread install.ps1 Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants