chore: rename DeploymentEvent to LifecycleEvent to ensure we have consistent naming.#10795
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames DeploymentEvent to LifecycleEvent and determineDeploymentEvent to determineLifecycleEvent across several files in the functions deployment pipeline to align with the concept of lifecycle hooks. The review feedback points out an opportunity to improve type safety in src/deploy/functions/prompts.ts by replacing an unsafe type assertion (hookName as LifecycleEvent) with an explicit check, adhering to the repository's TypeScript style guide.
… naming around this feature.
ajperel
force-pushed
the
ajp/deploymentevent-to-lifecycleevent
branch
from
d944b76 to
54d8cff
Compare
wandamora
approved these changes
Jul 13, 2026
wandamora
left a comment
wandamora
left a comment
Contributor
There was a problem hiding this comment.
LGTM, and ran some manual tests in a firebase project to verify this is WAI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming DeploymentEvent to LifecycleEvent to have consistent naming across hooks & events with new lifecycle features. This also improves the typing of lifecycleHooks in the Backend interface to guarantee the key is always a LifecycleEvent.
Scenarios Tested