Skip to content

chore(renovate): Configure #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RasmusRendal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(renovate): Configure #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{

@tlater-famedly tlater-famedly Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be generating this file with filegen, so all projects get renovate config by default?

"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:recommended",
"schedule:daily",
"schedule:automergeDaily"
],
Comment thread
cursor[bot] marked this conversation as resolved.
"timezone": "Europe/Vienna",
"enabledManagers": [
"nix"
],
"nix": {
"enabled": true
},
"lockFileMaintenance": {

@tlater-famedly tlater-famedly Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty common for flake inputs to change their inputs, causing .follows to get out of sync. We should add a flake-edit follow to our prek hooks to ensure this doesn't cause problems.

"enabled": true,
"schedule": "before 4am"
}
}

@cursor cursor Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renovate skips required filegen step

Medium Severity

The new Renovate setup updates flake.lock (and possibly flake.nix) but does not run nix run .#filegen-activate, which the README documents as mandatory after dependency updates. CI runs the filegen pre-commit hook via prek, so PRs that change flake inputs without refreshing generated .github/workflows and .pre-commit-config.yaml can fail even when the lock bump itself is valid.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7e28abb. Configure here.

@RasmusRendal RasmusRendal Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've put some care into not having nix store paths in the generated files any more, so this should only really be a problem for downstream repositories when ES changes the filegen output intentionally.

@tlater-famedly tlater-famedly Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to flake inputs might also introduce changes to e.g. treefmt.toml. This risks devshell components not being compatible with their configuration files.

It's a small risk, but worth considering.