Skip to content
This repository was archived by the owner on Mar 1, 2026. It is now read-only.

set m_read_opts.ignore_range_deletions properly #1218

Open
rockeet wants to merge 2 commits into
base: fb-mysql-8.0.28
Choose a base branch
from
Open

set m_read_opts.ignore_range_deletions properly #1218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43cf756
set m_read_opts.ignore_range_deletions properly
rockeet Aug 28, 2022
b0030b3
set m_read_opts.ignore_range_deletions - fix missing changes
rockeet Aug 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion storage/rocksdb/ha_rocksdb.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4232,7 +4232,10 @@ class Rdb_transaction {
}

explicit Rdb_transaction(THD *const thd)
: m_thd(thd), m_tbl_io_perf(nullptr) {}
: m_thd(thd), m_tbl_io_perf(nullptr) {
m_read_opts.ignore_range_deletions =
!rocksdb_enable_delete_range_for_drop_index;
}

virtual ~Rdb_transaction() {
#ifndef NDEBUG
Expand Down Expand Up @@ -4677,6 +4680,8 @@ class Rdb_transaction_impl : public Rdb_transaction {
m_rocksdb_reuse_tx[table_type] = nullptr;

m_read_opts = rocksdb::ReadOptions();
m_read_opts.ignore_range_deletions =
!rocksdb_enable_delete_range_for_drop_index;

set_initial_savepoint();

Expand Down Expand Up @@ -4800,6 +4805,8 @@ class Rdb_writebatch_impl : public Rdb_transaction {
void reset() {
m_batch->Clear();
m_read_opts = rocksdb::ReadOptions();
m_read_opts.ignore_range_deletions =
!rocksdb_enable_delete_range_for_drop_index;
m_ddl_transaction = false;
}

Expand Down