Skip to content

Fix bare except: use specific exception types #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix bare except: use specific exception types #14000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b4b76
Fix bare except: replace with except Exception: in callbacks.py
koteshyelamati Jul 19, 2026
ab1f89f
Fix bare except: replace with except Exception: in cli/_util.py
koteshyelamati Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spacy/cli/_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def get_git_version(
"""
try:
ret = run_command("git --version", capture=True)
except:
except Exception:
raise RuntimeError(error)
stdout = ret.stdout.strip()
if not stdout or not stdout.startswith("git version"):
Expand Down
2 changes: 1 addition & 1 deletion spacy/ml/callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def pipes_with_nvtx_range(
# the original parameters are passed to pydantic for validation downstream.
try:
wrapped_func.__signature__ = inspect.signature(func) # type: ignore
except:
except Exception:
# Can fail for Cython methods that do not have bindings.
warnings.warn(Warnings.W122.format(method=name, pipe=pipe.name))
continue
Expand Down