Skip to content

Include ref.parent matches in events by-reference navigation #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Include ref.parent matches in events by-reference navigation #2280

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f09562e
fix(events): include parent references in by-ref navigation
Copilot Jun 1, 2026
8f5e641
test(http): cover event by-reference routes
niemyjski Jul 10, 2026
ae3cc52
Merge origin/main into copilot/fix-parent-url-navigation
niemyjski Jul 16, 2026
311c5d5
Merge remote-tracking branch 'origin/main' into issue/pr-2280-parent-…
niemyjski Jul 21, 2026
6f152ed
fix(events): keep parent navigation available on free plans
niemyjski Jul 21, 2026
775c14f
fix(events): index parent references for free plans
niemyjski Jul 21, 2026
0e94773
fix(events): validate and align reference filters
niemyjski Jul 21, 2026
5f0dd46
fix(events): backfill retained parent references
niemyjski Jul 21, 2026
6942014
Merge remote-tracking branch 'origin/main' into issue/pr-2280-parent-…
niemyjski Jul 26, 2026
a507d66
fix(events): align free parent reference navigation
niemyjski Jul 26, 2026
85e61ce
fix(events): preserve legacy references and migration safety
niemyjski Jul 26, 2026
3e5f263
fix(events): backfill cased parent references
niemyjski Jul 26, 2026
d7a0b37
fix(events): report truncated reference results
niemyjski Jul 26, 2026
2991ef0
fix(events): recognize reference field names
niemyjski Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Exceptionless.Core/Repositories/Queries/Validation/PersistentEventQueryValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public sealed class PersistentEventQueryValidator : AppQueryValidator
"date",
"type",
EventIndex.Alias.ReferenceId,
"idx.parent-r",
Comment thread
niemyjski marked this conversation as resolved.
Outdated
"reference_id",
EventIndex.Alias.OrganizationId,
"organization_id",
Expand Down
4 changes: 2 additions & 2 deletions src/Exceptionless.Web/Api/Handlers/EventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ public async Task<Result<PagedResult<object>>> Handle(GetEventsByReferenceId mes

var ti = TimeRangeParser.GetTimeInfo(null, message.Offset, timeProvider, _allowedDateFields, DefaultDateField, organizations.GetRetentionUtcCutoff(appOptions.MaximumRetentionDays, timeProvider));
var sf = new AppFilter(organizations) { IsUserOrganizationsFilter = true };
return await GetInternalAsync(sf, ti, httpContext, String.Concat("reference:", message.ReferenceId), null, message.Mode, message.Page, message.Limit, message.Before, message.After, includeTotal: ShouldIncludeTotal(message.Include));
return await GetInternalAsync(sf, ti, httpContext, $"(reference:{message.ReferenceId} OR ref.parent:{message.ReferenceId})", null, message.Mode, message.Page, message.Limit, message.Before, message.After, includeTotal: ShouldIncludeTotal(message.Include));
Comment thread
niemyjski marked this conversation as resolved.
Outdated
Comment thread
niemyjski marked this conversation as resolved.
Outdated
}

public async Task<Result<PagedResult<object>>> Handle(GetEventsByReferenceIdAndProject message)
Expand All @@ -249,7 +249,7 @@ public async Task<Result<PagedResult<object>>> Handle(GetEventsByReferenceIdAndP

var ti = TimeRangeParser.GetTimeInfo(null, message.Offset, timeProvider, _allowedDateFields, DefaultDateField, organization.GetRetentionUtcCutoff(project, appOptions.MaximumRetentionDays, timeProvider));
var sf = new AppFilter(project, organization);
return await GetInternalAsync(sf, ti, httpContext, String.Concat("reference:", message.ReferenceId), null, message.Mode, message.Page, message.Limit, message.Before, message.After, includeTotal: ShouldIncludeTotal(message.Include));
return await GetInternalAsync(sf, ti, httpContext, $"(reference:{message.ReferenceId} OR ref.parent:{message.ReferenceId})", null, message.Mode, message.Page, message.Limit, message.Before, message.After, includeTotal: ShouldIncludeTotal(message.Include));
}

public async Task<Result<PagedResult<object>>> Handle(GetEventsBySessionId message)
Expand Down
27 changes: 27 additions & 0 deletions tests/Exceptionless.Tests/Api/Endpoints/EventEndpointTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,33 @@ public async Task GetByReferenceIdAsync_WithExistingReference_ReturnsMatchingEve
Assert.Equal(referenceId, ev.ReferenceId);
}

[Theory]
[InlineData(false)]
[InlineData(true)]
public async Task GetByReferenceIdAsync_WithOnlyParentReference_ReturnsMatchingEvents(bool projectScoped)
{
// Arrange
string referenceId = Guid.NewGuid().ToString("N");
await CreateDataAsync(d => d.Event().FreeProject().Reference("parent", referenceId).Message("parent reference route"));
await RefreshDataAsync();

string[] paths = projectScoped
? ["projects", SampleDataService.FREE_PROJECT_ID, "events", "by-ref", referenceId]
: ["events", "by-ref", referenceId];

// Act
var events = await SendRequestAsAsync<IReadOnlyCollection<PersistentEvent>>(r => r
.AsFreeOrganizationUser()
.AppendPaths(paths)
.StatusCodeShouldBeOk()
);

// Assert
Assert.NotNull(events);
var ev = Assert.Single(events);
Assert.Equal(referenceId, ev.GetEventReference("parent"));
}

[Fact]
public async Task GetCountByOrganizationAsync_WithExistingEvents_ReturnsOrganizationCount()
{
Expand Down
1 change: 1 addition & 0 deletions tests/Exceptionless.Tests/Search/PersistentEventQueryValidatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public PersistentEventQueryValidatorTests(ITestOutputHelper output) : base(outpu
[InlineData("organization:404", "organization:404", true, false)]
[InlineData("project:404", "project:404", true, false)]
[InlineData("stack:404", "stack:404", true, false)]
[InlineData("ref.parent:12345678", "idx.parent-r:12345678", true, false)]
[InlineData("ref.session:12345678", "idx.session-r:12345678", true, true)]
[InlineData("status:open", "status:open", true, false)]
public async Task CanProcessQueryAsync(string query, string expected, bool isValid, bool usesPremiumFeatures)
Expand Down
8 changes: 8 additions & 0 deletions tests/http/events.http
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ Content-Type: application/json
"reference_id": "{{referenceId}}"
}

### By ReferenceId
GET {{apiUrl}}/events/by-ref/{{referenceId}}
Authorization: Bearer {{token}}

### By ReferenceId And Project
GET {{apiUrl}}/projects/{{projectId}}/events/by-ref/{{referenceId}}
Authorization: Bearer {{token}}

### Post User Description
POST {{apiUrl}}/events/by-ref/{{referenceId}}/user-description?access_token={{clientToken}}
Content-Type: application/json
Expand Down
Loading