Add supported stack sort controls to the Svelte UI#2278
Conversation
|
|
Co-authored-by: niemyjski <1020579+niemyjski@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6d3929e96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # src/Exceptionless.Web/ClientApp/src/lib/features/events/components/table/options.svelte.test.ts # src/Exceptionless.Web/ClientApp/src/lib/features/events/components/table/options.svelte.ts # src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte
|
Follow-up reviewer-feedback and thermo-nuclear audit completed against live head Feedback classification:
The complete five-file branch-vs-main diff also passed the requested thermo-nuclear structural review: no spaghetti/branch growth, boundary leak, duplicate canonical helper, cast/optionality churn affecting correctness, non-atomic update, unnecessary sequential orchestration, or 1,000-line threshold crossing. The 19-line header component earns its boundary by centralizing and testing the accessible pressed-state interaction; no safe code-judo simplification remains beyond removing the unsupported First mode. Verification on the live head:
No follow-up code change was required. The sole remaining blocker is the pending external Copilot contributor CLA. |
What changed
Why
The original implementation exposed generic TanStack sorting, which caused stack requests to return HTTP 400 and attempted to sort session duration by a field the API does not provide. This keeps the feature Svelte-only while using the backend contract that already exists.
Verification
Runtime QA
Local AppHost startup was attempted with workspace-isolated Aspire state, but timed out after 120 seconds at Determining projects to restore. Other running Exceptionless worktrees were left untouched, so browser dogfood was not claimed against a different checkout.
Breaking changes
None.