cmd/evm, core: fixes for eels tests@v20.0.0 release#35283
Open
spencer-tb wants to merge 3 commits into
Open
Conversation
spencer-tb
commented
Jul 2, 2026
| if evm.StateDB.GetCodeSize(addr) == 0 { | ||
| return nil, nil, fmt.Errorf("requests contract %v has no code", addr) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Fixes the following test fails for CancunToPragueAtTime15k:
tests/prague/eip7002_el_triggerable_withdrawals/test_contract_deployment.py::test_system_contract_deployment[...-deploy_after_fork-zero_balance]and[...-deploy_after_fork-nonzero_balance]tests/prague/eip7251_consolidations/test_contract_deployment.py::test_system_contract_deployment[...-deploy_after_fork-zero_balance]and[...-deploy_after_fork-nonzero_balance]
Member
There was a problem hiding this comment.
This adds two state reads into the hot path. I would rather not add this and skip the tests instead.
Contributor
Author
There was a problem hiding this comment.
Removed it and added to skip list.
spencer-tb
commented
Jul 2, 2026
| // the EIP150 and EIP158 rulesets. | ||
| Forks["TangerineWhistle"] = Forks["EIP150"] | ||
| Forks["SpuriousDragon"] = Forks["EIP158"] | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Purposely using an alias here but can obvs be something else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sanity fixes surfaced by running the EELS
tests@v20.0.0fixture release (63,109 blockchain tests) throughevm blocktest.Also bumps CI to consume the new release:
build/checksums.txtnow points attests@v20.0.0/fixtures.tar.gzfromethereum/execution-specs(supersedes the archived EEST repo'sfixtures_develop).