p2p: skip netrestrict check for nodes without resolved IP#35282
Open
cuiweixie wants to merge 1 commit into
Open
p2p: skip netrestrict check for nodes without resolved IP#35282cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
Hostname-only static nodes have no valid IP at checkDial time and are resolved later in dialTask. Applying netrestrict to them incorrectly rejected the dial before resolution could happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkDialwhen a node has no valid IP yet.dialTask; applying netrestrict before resolution incorrectly rejected them.Test plan
go test -short ./p2p/ -run TestDialSchedNetRestrict